feat: Migrate from the old exoPlayer to the new Media3#1470
Open
tevincent wants to merge 96 commits into
Open
Conversation
tevincent
force-pushed
the
player-background-rebased
branch
from
81dd46a to
7ef2289
Compare
|
tevincent
force-pushed
the
player-background-rebased
branch
from
7ef2289 to
bc2786e
Compare
tevincent
force-pushed
the
player-background-rebased
branch
from
b0a38a0 to
4e08fb9
Compare
tevincent
changed the title
tevincent
force-pushed
the
player-background-rebased
branch
2 times, most recently
from
a7c3e47 to
b8cbe3e
Compare
tevincent
force-pushed
the
player-background-rebased
branch
from
e9b974d to
a111513
Compare
tevincent
force-pushed
the
player-background-rebased
branch
7 times, most recently
from
026d15f to
d8d3b47
Compare
tevincent
force-pushed
the
player-background-rebased
branch
3 times, most recently
from
68b9f4c to
f415a6a
Compare
KevinBoulongne
force-pushed
the
player-background-rebased
branch
from
f415a6a to
860df34
Compare
tevincent
force-pushed
the
player-background-rebased
branch
from
860df34 to
f415a6a
Compare
|
# Conflicts: # app/src/main/java/com/infomaniak/drive/ui/fileList/preview/PreviewVideoFragment.kt
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates in-app media playback from legacy ExoPlayer (2.x) to AndroidX Media3, introducing a dedicated playback flow that supports background audio (via MediaSessionService) and video playback in a separate PIP-capable activity.
Changes:
- Replace legacy
com.google.android.exoplayer2dependencies withandroidx.media3modules (ExoPlayer/UI/OkHttp datasource/session). - Introduce
PreviewPlaybackFragment+PlaybackService/MediaSessioninfrastructure for background media controls. - Add
VideoActivityfor video playback with Picture-in-Picture support, and route preview video/audio to the new playback fragment.
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| gradle/libs.versions.toml | Swap legacy ExoPlayer coordinates for Media3 artifacts in version catalog. |
| app/build.gradle.kts | Update app dependencies to Media3 modules (dash/ui/datasource/session). |
| app/src/main/AndroidManifest.xml | Declare PIP VideoActivity, Media3 PlaybackService, and media playback foreground service permission. |
| app/src/main/res/navigation/main_navigation.xml | Add Navigation destination + SafeArgs for VideoActivity with fileId. |
| app/src/main/res/layout/fragment_preview_playback.xml | Replace legacy player view with Media3 PlayerView. |
| app/src/main/res/layout/activity_video.xml | New layout for dedicated video/PIP activity using Media3 PlayerView. |
| app/src/main/java/com/infomaniak/drive/utils/Extensions.kt | Add helper to exclude activities from recents. |
| app/src/main/java/com/infomaniak/drive/ui/MainActivity.kt | Bring VideoActivity to front when returning from PIP. |
| app/src/main/java/com/infomaniak/drive/ui/fileList/preview/PreviewSliderAdapter.kt | Route VIDEO/AUDIO previews to the new PreviewPlaybackFragment. |
| app/src/main/java/com/infomaniak/drive/ui/fileList/preview/PreviewVideoFragment.kt | Remove legacy ExoPlayer video preview implementation. |
| app/src/main/java/com/infomaniak/drive/ui/fileList/preview/PreviewMusicFragment.kt | Remove legacy audio preview subclass. |
| app/src/main/java/com/infomaniak/drive/ui/fileList/preview/playback/PreviewPlaybackFragment.kt | New unified Media3 playback fragment + video handoff to VideoActivity. |
| app/src/main/java/com/infomaniak/drive/ui/fileList/preview/playback/VideoActivity.kt | New Media3-based video activity with PIP handling. |
| app/src/main/java/com/infomaniak/drive/ui/fileList/preview/playback/PlaybackUtils.kt | Centralize player/session/controller creation, media item creation, and PIP params. |
| app/src/main/java/com/infomaniak/drive/ui/fileList/preview/playback/PlaybackService.kt | New MediaSessionService for background playback + notification controls. |
| app/src/main/java/com/infomaniak/drive/ui/fileList/preview/playback/PlaybackViewModel.kt | Load file/offline state for VideoActivity playback. |
| app/src/main/java/com/infomaniak/drive/ui/fileList/preview/playback/PlayerListener.kt | Media3 player listener for analytics + error forwarding. |
| app/src/main/java/com/infomaniak/drive/ui/BasePreviewSliderFragment.kt | Track playback positions across swipes and release player resources on destroy. |
| app/src/main/java/com/infomaniak/drive/MainApplication.kt | Track whether VideoActivity is currently in PIP mode. |
| app/src/main/java/com/infomaniak/drive/data/models/File.kt | Add isVideo() helper used by the new playback flow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…null if we cannot compute the value
# Conflicts: # Core
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on #1583
new_player.mp4