Skip to content

refactor: Remove middle class#172

Merged
LouisCAD merged 1 commit intomainfrom
remove-middle-class
May 7, 2026
Merged

refactor: Remove middle class#172
LouisCAD merged 1 commit intomainfrom
remove-middle-class

Conversation

@LouisCAD
Copy link
Copy Markdown
Contributor

@LouisCAD LouisCAD commented May 7, 2026

This commit merges the WebAuthnRepository and AuthenticatorRequest classes into one, named WebAuthnRequests.

This commit merges the WebAuthnRepository and AuthenticatorRequest classes
into one, named WebAuthnRequests.
Copilot AI review requested due to automatic review settings May 7, 2026 14:36
@LouisCAD LouisCAD enabled auto-merge May 7, 2026 14:37
@LouisCAD LouisCAD requested a review from tevincent May 7, 2026 14:37
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR removes the repository layer by merging WebAuthnRepository and AuthenticatorRequest into a single request component (WebAuthnRequests) and updates managers/facade wiring accordingly.

Changes:

  • Replace AuthenticatorRequest/WebAuthnRepository with WebAuthnRequests and update call sites.
  • Simplify API methods to return .data models directly instead of SuccessfulApiResponse<T>.
  • Move “ignore 404” logic for passkey deletion into the requests layer.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
multiplatform-lib/src/commonMain/kotlin/internal/requests/AuthenticatorRequest.kt Renames/repurposes request class into WebAuthnRequests, changes return types to unwrap .data, and adds 404-tolerant deletion.
multiplatform-lib/src/commonMain/kotlin/internal/repositories/WebAuthnRepository.kt Removes the repository wrapper entirely.
multiplatform-lib/src/commonMain/kotlin/internal/managers/MigrationManager.kt Swaps dependency from repository to WebAuthnRequests.
multiplatform-lib/src/commonMain/kotlin/internal/managers/AuthenticatorManager.kt Updates WebAuthn calls to use WebAuthnRequests and adjusted return types.
multiplatform-lib/src/commonMain/kotlin/internal/managers/AccountRestorer.kt Updates passkey deletion calls to use WebAuthnRequests.
multiplatform-lib/src/commonMain/kotlin/AuthenticatorFacade.kt Updates DI/wiring to construct and pass WebAuthnRequests instead of repository + request.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 7, 2026

@LouisCAD LouisCAD merged commit d7846ae into main May 7, 2026
15 of 16 checks passed
@LouisCAD LouisCAD deleted the remove-middle-class branch May 7, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants