Conversation
This commit merges the WebAuthnRepository and AuthenticatorRequest classes into one, named WebAuthnRequests.
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR removes the repository layer by merging WebAuthnRepository and AuthenticatorRequest into a single request component (WebAuthnRequests) and updates managers/facade wiring accordingly.
Changes:
- Replace
AuthenticatorRequest/WebAuthnRepositorywithWebAuthnRequestsand update call sites. - Simplify API methods to return
.datamodels directly instead ofSuccessfulApiResponse<T>. - Move “ignore 404” logic for passkey deletion into the requests layer.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| multiplatform-lib/src/commonMain/kotlin/internal/requests/AuthenticatorRequest.kt | Renames/repurposes request class into WebAuthnRequests, changes return types to unwrap .data, and adds 404-tolerant deletion. |
| multiplatform-lib/src/commonMain/kotlin/internal/repositories/WebAuthnRepository.kt | Removes the repository wrapper entirely. |
| multiplatform-lib/src/commonMain/kotlin/internal/managers/MigrationManager.kt | Swaps dependency from repository to WebAuthnRequests. |
| multiplatform-lib/src/commonMain/kotlin/internal/managers/AuthenticatorManager.kt | Updates WebAuthn calls to use WebAuthnRequests and adjusted return types. |
| multiplatform-lib/src/commonMain/kotlin/internal/managers/AccountRestorer.kt | Updates passkey deletion calls to use WebAuthnRequests. |
| multiplatform-lib/src/commonMain/kotlin/AuthenticatorFacade.kt | Updates DI/wiring to construct and pass WebAuthnRequests instead of repository + request. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
tevincent
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This commit merges the
WebAuthnRepositoryandAuthenticatorRequestclasses into one, namedWebAuthnRequests.