fix: Fix too restrictive precondition that was causing rare failures on iOS#169
Merged
fix: Fix too restrictive precondition that was causing rare failures on iOS#169
Conversation
…on iOS These could be recovered from by just killing and restarting the app, but it's best that users don't need to do that ever.
There was a problem hiding this comment.
Pull request overview
Relaxes an overly strict precondition in the iOS (appleMain) signature parsing utility to prevent rare ECDSA signature conversion failures that previously required restarting the app to recover.
Changes:
- Broadened the accepted DER ECDSA signature length range from
70..72to8..72. - Updated the associated error message and added an explanatory inline comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
lebojo
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These could be recovered from by just killing and restarting the app, but it's best that users don't need to do that ever.