Skip to content

chore: Add configuration files for password autofill#167

Merged
tevincent merged 3 commits intomainfrom
handle-autofill
May 6, 2026
Merged

chore: Add configuration files for password autofill#167
tevincent merged 3 commits intomainfrom
handle-autofill

Conversation

@tevincent
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings May 6, 2026 11:19
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds Android Digital Asset Links asset_statements metadata to support password autofill / Credential Manager association between the app and the Infomaniak login domain.

Changes:

  • Added a new @string/asset_statements JSON payload intended for Digital Asset Links.
  • Registered the asset_statements string resource in AndroidManifest.xml via <meta-data>.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
app/src/main/res/values/non_translatable_strings.xml Adds the Digital Asset Links asset_statements JSON payload (currently malformed).
app/src/main/AndroidManifest.xml Registers the asset_statements metadata pointing to the new string resource.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread app/src/main/res/values/non_translatable_strings.xml Outdated
Comment thread app/src/main/res/values/non_translatable_strings.xml Outdated
Comment thread app/src/main/res/values/non_translatable_strings.xml Outdated
Comment thread app/src/main/res/values/non_translatable_strings.xml
Comment thread app/src/main/res/values/non_translatable_strings.xml
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comment thread app/src/main/res/values/non_translatable_strings.xml
Comment thread app/src/main/res/values/non_translatable_strings.xml
@tevincent tevincent marked this pull request as draft May 6, 2026 11:46
@tevincent tevincent marked this pull request as ready for review May 6, 2026 14:05
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 6, 2026

@tevincent tevincent merged commit e8748ec into main May 6, 2026
9 checks passed
@tevincent tevincent deleted the handle-autofill branch May 6, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants