Skip to content

Fix/ctest timeout fix #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kilinchange merged 1 commit into from
Jun 9, 2026
Merged

Fix/ctest timeout fix #171

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions cmake/test_macros.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@ include(GoogleTest)
# Arguments:
# SOURCES: Source file list (required)
# LABELS: Test labels, e.g. "cpu" "cuda" "distributed" (optional, default "cpu")
# TEST_FILTER: gtest test filter pattern (optional)
# TEST_FILTER: gtest test filter pattern (optional)
# TEST_TIMEOUT: ctest timeout in seconds (optional, default 10)
#
# Examples:
# # Single-label test (one liner)
Expand All @@ -45,7 +46,7 @@ include(GoogleTest)
# infini_train_add_test(test_example_cuda SOURCES test_example.cc LABELS cuda TEST_FILTER "*CUDA*")
# -----------------------------------------------------------------------------
macro(infini_train_add_test)
cmake_parse_arguments(ARG "" "TEST_NAME;TEST_FILTER" "SOURCES;LABELS" ${ARGN})
cmake_parse_arguments(ARG "" "TEST_NAME;TEST_FILTER;TEST_TIMEOUT" "SOURCES;LABELS" ${ARGN})

if(NOT ARG_TEST_NAME)
set(ARG_TEST_NAME ${ARG_UNPARSED_ARGUMENTS})
Expand Down Expand Up @@ -78,17 +79,22 @@ macro(infini_train_add_test)
set(labels "${ARG_LABELS}")
endif()

set(test_timeout 10)
if(ARG_TEST_TIMEOUT)
set(test_timeout ${ARG_TEST_TIMEOUT})
endif()

if(ARG_TEST_FILTER)
gtest_discover_tests(${ARG_TEST_NAME}
EXTRA_ARGS --gtest_output=xml:%T.xml
TEST_FILTER "${ARG_TEST_FILTER}"
DISCOVERY_TIMEOUT 10
PROPERTIES LABELS "${labels}" TIMEOUT 10
PROPERTIES LABELS "${labels}" TIMEOUT ${test_timeout}
)
else()
gtest_discover_tests(${ARG_TEST_NAME}
EXTRA_ARGS --gtest_output=xml:%T.xml
PROPERTIES LABELS "${labels}" TIMEOUT 10
PROPERTIES LABELS "${labels}" TIMEOUT ${test_timeout}
)
endif()
endmacro()
Expand All @@ -103,26 +109,33 @@ endmacro()
# <name> Base name; each target is named <name>_<label>
# SOURCES Source file list (required)
# LABELS Subset of {cpu cuda} (optional, default: both)
# TEST_TIMEOUT ctest timeout in seconds (optional, default 10)
#
# Examples:
# infini_train_add_test_suite(test_tensor SOURCES ${TENSOR_TEST_SOURCES})
# infini_train_add_test_suite(test_lora SOURCES test_lora.cc LABELS cpu)
# -----------------------------------------------------------------------------
macro(infini_train_add_test_suite)
cmake_parse_arguments(SUITE "" "" "SOURCES;LABELS" ${ARGN})
cmake_parse_arguments(SUITE "" "TEST_TIMEOUT" "SOURCES;LABELS" ${ARGN})
set(_suite_name ${SUITE_UNPARSED_ARGUMENTS})

if(NOT SUITE_LABELS)
set(SUITE_LABELS cpu cuda)
endif()

set(suite_test_timeout 10)
if(SUITE_TEST_TIMEOUT)
set(suite_test_timeout ${SUITE_TEST_TIMEOUT})
endif()

foreach(_label IN LISTS SUITE_LABELS)
string(TOUPPER ${_label} _label_upper)
set(_filter "${_label_upper}/*")
infini_train_add_test(${_suite_name}_${_label}
SOURCES ${SUITE_SOURCES}
LABELS ${_label}
TEST_FILTER "${_filter}"
TEST_TIMEOUT ${suite_test_timeout}
)
endforeach()
endmacro()
Loading