Skip to content

Fix/initial-client-list-loading #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kshitiz1403 wants to merge 3 commits into
base: master
Choose a base branch
from
+8 −2
Open

Fix/initial-client-list-loading #59

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1afdcac
fix: missing dependencies in Dockerfile would break the build
Kshitiz1403 Feb 26, 2025
e98197a
fix: ensure client list loads on initial page load
Kshitiz1403 Feb 26, 2025
7633253
Revert "fix: ensure client list loads on initial page load"
Kshitiz1403 Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions web/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,13 @@ WORKDIR /usr/src/app

ENV DOCKERIZE_VERSION v0.6.0

# Add build dependencies before npm install
RUN apk update \
&& apk add --no-cache --virtual .build-deps \
make \
g++ \
&& apk add --no-cache --virtual .run-deps \
curl nginx supervisor nodejs npm \
curl nginx supervisor nodejs npm \
&& wget https://github.com/jwilder/dockerize/releases/download/$DOCKERIZE_VERSION/dockerize-alpine-linux-amd64-$DOCKERIZE_VERSION.tar.gz \
&& tar -C /usr/local/bin -xzvf dockerize-alpine-linux-amd64-$DOCKERIZE_VERSION.tar.gz \
&& rm dockerize-alpine-linux-amd64-$DOCKERIZE_VERSION.tar.gz
Expand All @@ -23,7 +27,9 @@ RUN chown -R nginx:nginx /var/www \
# Install app dependencies
COPY *.json /usr/src/app/

RUN npm install
RUN npm install \
# Remove build dependencies after npm install to reduce image size
&& apk del .build-deps

# # Bundle app source
COPY . /usr/src/app
Expand Down