SEP-38 quote display - Show fiat↔asset quotes (RFQ) before confirming an anchor transfer - #390
Open
Binali223 wants to merge 1 commit into
Open
Conversation
- Create backend SEP-38 module with GET /sep38/quote endpoint - Add frontend SEP-38 types, service, and API constant - Insert quote review step in SEP-24 wizard between form and interactive - Display fiat-to-asset exchange rate, amount, fee, and expiry - Simulate quotes with realistic fiat rates for development Closes Ignition-World#290
|
@Binali223 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Show fiat↔asset quotes (RFQ) before confirming an anchor transfer.
Changes
Backend (
ignition-api)Sep38ModulewithPOST /api/v1/sep38/quoteendpointanchorName,sellAsset,buyAsset,sellAmountAppModuleFrontend (
ignition-pay-frontend)sep38.quoteendpoint to API constantsQuoteRequest/QuoteResponsetypes to anchor modelsfetchQuote()service functionFlow
operation → form (select asset + enter amount) → quote (review rate) → interactive (iframe) → completedCloses #290