🐛🎨Alignment of required/computed resources when running dynamic services#9237
Draft
sanderegg wants to merge 4 commits into
Draft
🐛🎨Alignment of required/computed resources when running dynamic services#9237sanderegg wants to merge 4 commits into
sanderegg wants to merge 4 commits into
Conversation
sanderegg
added
a:webserver
github-actions
Bot
added
a:infra+ops
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #9237 +/- ##
==========================================
- Coverage 87.04% 86.08% -0.96%
==========================================
Files 2019 2059 +40
Lines 79080 81709 +2629
Branches 1502 1502
==========================================
+ Hits 68832 70340 +1508
- Misses 9837 10958 +1121
Partials 411 411
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
sanderegg
force-pushed
the
uniformize-dynamic-services-resources-allocation
branch
from
3cc7b25 to
c119980
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…able resources
What do these changes do?
it was found by analysing https://github.com/ITISFoundation/private-issues/issues/455 that resources are not computed similarly between autoscaling and director-v2/webserver with regard to dynamic services.
This led to the issue described in https://github.com/ITISFoundation/private-issues/issues/455.
The director-v2/webserver is responsible for computing how much resources a user service needs (with the addition of the dynamic-sidecar own resources and the dynamic-proxy own resources). This is then set on the services.
The autoscaling services reads these resources and takes the largest between docker reservations and limits. If this is above what is available on a selected EC2 machine type, then it raises an error which is correct.
The issue above appears when using small EC2 machine types, where the director/webserver uses some flooring mechanism that actually does not account for the fact that the machine type is not large enough to accomodate the service. Instead of failing fast, then the the service is started and fails later with confusing errors or even none.
This PR aims at aligning both subsystems by having a clear location where the computations of dynamic-sidecar/-proxy services resources are done.
Related issue/s
How to test
Dev-ops