Report the "base roots" when checking alignment.#4
Merged
Conversation
If the alignment check is restricted to base entities only (option `robot.report.use_base_iris` set to True), then we ask the `odk:check-align` command to report, not only the top-level unaligned classes, but the all unaligned classes down to the highest "in-base" ancestors. Presumably if the ontology owner is only interested in the alignment of their own classes, they'd want to know what are highest unaligned classes **in their ontology's namespace(s)**.
Collaborator
Author
|
Draft PR as this requires a new release of the ODK plugin. @matentzn Do you have any new feature in mind for the plugin that you would want to see in a 0.3.1 release? |
For the current state of the debate, this is doing what it needs to! I am confident we are good for at least 6 months. Thanks for asking! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the alignment check is restricted to base entities only (option
robot.report.use_base_irisset to True), then we ask theodk:check-aligncommand to report, not only the top-level unaligned classes, but the all unaligned classes down to the highest "in-base" ancestors.Presumably if the ontology owner is only interested in the alignment of their own classes, they'd want to know what are highest unaligned classes in their ontology's namespace(s).