BookingPool 48018: Redirect to Post-Booking Information#11737
Merged
Conversation
See: https://mantis.ilias.de/view.php?id=48018 After booking from the bookable items table, users were not sent to post-booking information when an item had post text or a file attached. `BookableItemTableBookAction` now collects reservation ids and redirects to `displayPostInfo` when bookings succeed. `ProcessUtilGUI::displayPostInfo()` was refactored to resolve periods per object, render one info block per bookable item with booking information, and support multiple objects via `book_post_booking_information_for`. Added `BookingsTableBookingInformationAction` for the bookings table and handled `returnCmd` `render` in `back()`.
Contributor
|
Hey @matheuszych, thanks for the PR. Kind Regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: https://mantis.ilias.de/view.php?id=48018
After booking from the bookable items table, users were not sent to post-booking information when an item had post text or a file attached.
BookableItemTableBookActionnow collects reservation ids and redirects todisplayPostInfowhen bookings succeed.ProcessUtilGUI::displayPostInfo()was refactored to resolve periods per object, render one info block per bookable item with booking information, and support multiple objects viabook_post_booking_information_for. AddedBookingsTableBookingInformationActionfor the bookings table and handledreturnCmdrenderinback()./cc @thojou