Feat: EAP Feedback batch II - #2523
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 5c14fee The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
frozenhelium
requested changes
Aug 26, 2026
Member
There was a problem hiding this comment.
We should use DistrictSearchSelectInput
Comment on lines
+82
to
+83
| const showAdmin1 = (value?.districts?.length ?? 0) > 0 || hasAdmin2 === false; | ||
| const showAdmin2 = (value?.admin2?.length ?? 0) > 0 || hasAdmin2 === true; |
Member
There was a problem hiding this comment.
Suggested change
| const showAdmin1 = (value?.districts?.length ?? 0) > 0 || hasAdmin2 === false; | |
| const showAdmin2 = (value?.admin2?.length ?? 0) > 0 || hasAdmin2 === true; | |
| const showAdmin2 = (value?.admin2?.length ?? 0) > 0 || hasAdmin2 === true; | |
| const showAdmin1 = !showAdmin2 && (value?.districts?.length ?? 0) > 0; |
Member
There was a problem hiding this comment.
Let make them mutually exclusive
Member
There was a problem hiding this comment.
We'll need to regenerate this
crsstha
force-pushed
the
feat/eap-feedback-batch-second
branch
from
August 26, 2026 06:21
3c0bfbb to
83de0e9
Compare
crsstha
force-pushed
the
feat/eap-feedback-batch-second
branch
2 times, most recently
from
September 1, 2026 04:09
a25768f to
20cffef
Compare
frozenhelium
reviewed
Sep 1, 2026
Member
There was a problem hiding this comment.
Lets update the filename to reflect the behavior of component, something like Admin1MultiSelectWithDescriptionInput
crsstha
force-pushed
the
feat/eap-feedback-batch-second
branch
2 times, most recently
from
September 1, 2026 05:34
a59f101 to
3d8a88f
Compare
frozenhelium
approved these changes
Sep 1, 2026
frozenhelium
force-pushed
the
feat/eap-feedback-batch-second
branch
4 times, most recently
from
September 1, 2026 08:25
47b9c73 to
08c4eb2
Compare
- Add prioritised risks and early actions repeatable inputs to the sEAP Risk Analysis tab, with validation in the sEAP schema - Require a final review checklist upload when moving an EAP to technically validated, and expose it for download in the table actions - Derive early action activity timeframes from the lead time in previous sections, and word the hint per form type - Make the disaster sub type input always available on EAP registration instead of only for epidemic and other disaster types - Make trigger model lead time a number input - Require source name and drop the required source link on full EAP source information - Fall back to admin 1 selection for countries that have no admin 2 areas, so those EAPs can still record a location - Show the additional guidance text in the quality criteria modal on both the EAP and sEAP forms
frozenhelium
force-pushed
the
feat/eap-feedback-batch-second
branch
from
September 1, 2026 08:38
08c4eb2 to
5c14fee
Compare
frozenhelium
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Depends On
Changes
This PR Ensures:
console.logstatements meant for debuggingAdditional Notes
Optional: Add any other relevant context, screenshots, or details here.