Fix error for name of newly created feature model#1714
Merged
dbinkele merged 5 commits intomaintenance/mps20241from Apr 13, 2026
Merged
Conversation
88e6df0 to
d4498ff
Compare
…of_new_featuremodel_1713
…r_for_name_of_new_featuremodel_1713
Member
Author
|
Regarding @dbinkele 's offline question about using |
dbinkele
previously approved these changes
Apr 13, 2026
dbinkele
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The root feature of a newly created feature model deliberately lacks a name, thus an error is shown. This is correct.
However, the name of the feature model itself is derived from the root feature's name via a get-property constraint. As both the feature model concept and the root feature concept are implementing
IValidNamedConcept, the non-existent name of a new root feature will cause a second error for the name of the feature model. This second error will not vanish automatically after some valid name is entered, only after F5 is pressed additionally.This PR fixes the problem by assigning a specific
NO_NAMEname to feature models without root feature or with root features with an invalid name.This solves #1713.