Flash Unit and HDA Flowsheet Tutorial Revisions to reflect changes to initialization and scaling updates as well as some overall improvements #144
Conversation
…o initialization and scaling
…o initialization and scaling
…ues that were causing a failed pytest
…ues that were causing a failed pytest
…ues that were causing a failed pytest
…ues that were causing a failed pytest
…ues that were causing a failed pytest
…ues that were causing a failed pytest
tannerpolley
requested review from
MarcusHolly,
agarciadiego,
bpaul4 and
dallan-keylogic
|
This PR is waiting on IDAES/idaes-pse#1643 |
empty change to trigger github actions
…itialized the HDA flowsheet files to work with the modular properties framework. Currently not working due to unit model initialization error.
|
Now waiting on IDAES/idaes-pse#1646 , but also we might want to use a different set of state variables, FpcTP has issues with degeneracy when a phase disappears. |
* update to v4 * make names for each run be unique * make names for each run be unique with py version being tested * change naming mechanism to be more unique * experimenting with overwrite * mimic changes that worked one year ago by tanner * switch back to 22.04 * trying if this version will have the tests work * make name unique --------- Co-authored-by: Sufi Kaur <[email protected]>
Co-authored-by: Keith Beattie <[email protected]>
September 2025 Typos update
* Added links and references to background material * Forgot to save changes * Apply suggestions from code review Co-authored-by: Miranda Mundt <[email protected]> --------- Co-authored-by: Keith Beattie <[email protected]> Co-authored-by: Bethany Nicholson <[email protected]> Co-authored-by: Miranda Mundt <[email protected]>
|
@tannerpolley do you have time to look into this, perhaps restarting with a new PR? |
* New notebook soc_pid_con in directory docs/power_gen/solid_oxide_cell * Preliminary work on getting notebook ready. * bring pid example up to date * remember to save * do preprocessing * add soc_dynamic_flowsheet.svg to gitignore * make gitignore and checking results work * delete wrong flowsheet * update initial conditions * delete irrelevant file * update to merged crossflow_hx nomenclature * run idaesx pre * New notebook soc_steady_state_optimiza in directory docs/power_gen/solid_oxide_cell * steady state optimization * changes * new setpoint files * changes * fixes * optimization * experiments * merge cleanup * lower expectations * blah * bring in line with main * changes due to xflowhx fix * get changes from latest version of flowsheet * fix remaining issues with flowsheet * move LL deactivation * remember to commit jsons * optimization example not yet ready * black and install from PR * did the child notebooks not get updated? --------- Co-authored-by: Ludovico Bianchi <[email protected]> Co-authored-by: Keith Beattie <[email protected]>
|
@tannerpolley, pushing this to Feb '26 release as progress appears stalled. |
* revert installation from branch * revert requirements-dev
|
@ksbeattie @dallan-keylogic I just finished updating the HDA Flowsheet again with the new state definition but I ran build again and the same error occurred with the distorted HTML page. I can also just restart with a new PR if thats easier |
Thanks @tannerpolley, whatever is easier for you is fine. |
… the necessary supporting files to make it work. Included a Python file of the flowsheet.
…o initialization and scaling
…o initialization and scaling
…itialized the HDA flowsheet files to work with the modular properties framework. Currently not working due to unit model initialization error.
… the necessary supporting files to make it work. Included a Python file of the flowsheet.
…mples into Tutorial-Update # Conflicts: # .github/workflows/core.yml # idaes_examples/mod/hda/hda_ideal_VLE.py
|
@tannerpolley, I'm moving this back to "In Progress" since there are conflicts to resolve. You can take the incoming changes for the conflicts in |
… definition and initialization methods
|
@tannerpolley, this as shown here by github, is a very large PR that looks like has many changes that you are not intending to make as part of this PR. Maybe you need to re-create this PR with just your changes? |
8 participants
(From #143)
For the Flash Unit Model tutorial, changes include:
For the HDA Flowsheet Tutorial, changed include:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution:
📚 Documentation preview 📚: https://idaes-examples--144.org.readthedocs.build/en/144/