DOC: add Snap ML example#1426
Conversation
Signed-off-by: Amir <88084572+AmirhosseinHonardoust@users.noreply.github.com>
|
Hi Amir, thank you for your PR. However, I have a couple of concerns with it.
|
Updated the SnapML example to demonstrate pipeline composition and schema validation, using a Sphinx code block for proper rendering. Signed-off-by: AmirhosseinHonardoust <88084572+AmirhosseinHonardoust@users.noreply.github.comgit config --global user.name AmirhosseinHonardoustgit config --global user.email 88084572+AmirhosseinHonardoust@users.noreply.github.com>
Updated the SnapML example to demonstrate pipeline composition and schema validation, using a Sphinx code block for proper rendering. Signed-off-by: Amirhossein Honardoust <88084572+AmirhosseinHonardoust@users.noreply.github.com> Signed-off-by: AmirhosseinHonardoust <88084572+AmirhosseinHonardoust@users.noreply.github.comgit config --global user.name AmirhosseinHonardoustgit config --global user.email 88084572+AmirhosseinHonardoust@users.noreply.github.com>
Signed-off-by: Amir <88084572+AmirhosseinHonardoust@users.noreply.github.com> Signed-off-by: AmirhosseinHonardoust <88084572+AmirhosseinHonardoust@users.noreply.github.comgit config --global user.name AmirhosseinHonardoustgit config --global user.email 88084572+AmirhosseinHonardoust@users.noreply.github.com>
Updated the SnapML example to demonstrate pipeline composition and schema validation, using a Sphinx code block for proper rendering. Signed-off-by: Amir <amirhosseinhonardoust@gmail.com> Signed-off-by: AmirhosseinHonardoust <88084572+AmirhosseinHonardoust@users.noreply.github.comgit config --global user.name AmirhosseinHonardoustgit config --global user.email 88084572+AmirhosseinHonardoust@users.noreply.github.com>
Signed-off-by: Amir <88084572+AmirhosseinHonardoust@users.noreply.github.com> Signed-off-by: AmirhosseinHonardoust <88084572+AmirhosseinHonardoust@users.noreply.github.comgit config --global user.name AmirhosseinHonardoustgit config --global user.email 88084572+AmirhosseinHonardoust@users.noreply.github.com>
3020f00 to
7267029
Compare
|
Hi @hirzel , I updated the SnapML example to clearly demonstrate lale-specific features:
additionally, I rebased all commits to include thank you for reviewing |
|
Signed-off-by: AmirhosseinHonardoust <88084572+AmirhosseinHonardoust@users.noreply.github.com> Signed-off-by: Amir <88084572+AmirhosseinHonardoust@users.noreply.github.com>
620b8fb to
30fe179
Compare
|
Thank you @hirzel for the feedback. You were right: print_schema() does not exist, and using make_pipeline() with a single operator was unnecessary. I revised the example to keep it as a single SnapLogisticRegression operator while showing a Lale specific feature via |
|
Thanks! The code looks good now. There is one more piece of housekeeping. Could you please sign a DCO as outlined in contributing.md? You can email it to me: hirzel at us dot ibm dot com. |
|
The static checks revealed a problem in the black pretty-printer. This should be easy to resolve by running the pre-commit checks, as documented in contributing.md. |
Signed-off-by: AmirhosseinHonardoust <88084572+AmirhosseinHonardoust@users.noreply.github.comgit config --global user.name AmirhosseinHonardoustgit config --global user.email 88084572+AmirhosseinHonardoust@users.noreply.github.com> Signed-off-by: Amir <amirhosseinhonardoust@gmail.com>
4768821 to
1f2ff88
Compare
|
The Snap ML module has been reformatted using Black to ensure consistent and PEP8 compliant code style across the project. |
|
Thank you for your contribution! |
|
Thank you @hirzel for reviewing and merging my PR. I appreciate your guidance throughout the process. |
This PR adds a simple code example to the lale.lib.snapml module documentation.
The example shows how to use SnapLogisticRegression with a scikit-learn binary classification dataset, train/test split, prediction, and accuracy evaluation.
Related issue: #1368