Skip to content

ws_shard: make disable_memory_map a direct kwarg with auto-fallback o… #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tig888 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

ws_shard: make disable_memory_map a direct kwarg with auto-fallback o… #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions wsds/ws_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ def __init__(
dataset_root: str | Path,
include_in_progress: bool = True,
key_folder: str | None = None,
disable_memory_map: bool = False,
ignore_index: bool = False,
rng: random.Random | int | None = None,
):
Expand All @@ -75,7 +74,6 @@ def __init__(

self.index = None
self.segmented = False
self.disable_memory_map = disable_memory_map
index_file = self.dataset_root / "index.sqlite3"
if not ignore_index and index_file.exists():
self.index = WSIndex(index_file)
Expand Down
10 changes: 7 additions & 3 deletions wsds/ws_shard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,16 +42,20 @@ class WSShard(WSShardInterface):
batch_size: int
dataset: "WSDataset"

def __init__(self, dataset, fname, shard_ref=None):
def __init__(self, dataset, fname, shard_ref=None, *, disable_memory_map: bool = False):
self.dataset = dataset
self.shard_ref = shard_ref
self.fname = fname

try:
if dataset.disable_memory_map:
if disable_memory_map:
self._source_file = pa.OSFile(str(fname))
else:
self._source_file = pa.memory_map(str(fname))
try:
self._source_file = pa.memory_map(str(fname))
except OSError:
# filesystem doesn't support mmap (NFS, some container FS) — fall back
self._source_file = pa.OSFile(str(fname))
self.reader = pa.RecordBatchFileReader(self._source_file)
except FileNotFoundError:
raise WSShardMissingError(fname) from None
Expand Down