Add close() to WSShard and WSDataset to release file handles#62
Closed
shahbaz-humeai wants to merge 1 commit into
Closed
Add close() to WSShard and WSDataset to release file handles#62shahbaz-humeai wants to merge 1 commit into
shahbaz-humeai wants to merge 1 commit into
Conversation
WSShard now stores the pa.OSFile/memory_map handle separately and exposes close() to release it. WSDataset.close() iterates all cached open shards and closes them. Also fixes WSShard(dataset=None) crash on disable_memory_map access.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.