ws_dataset: add parallel_collect option to SQL query execution#59
Open
tig888 wants to merge 1 commit into
Open
ws_dataset: add parallel_collect option to SQL query execution#59tig888 wants to merge 1 commit into
tig888 wants to merge 1 commit into
Conversation
Adds a `parallel_collect` parameter to `_parse_sql_queries_polars` and `_execute_sql_queries_polars` that uses `pl.collect_all()` to collect all lazy frames in parallel before concatenation.
Member
|
This is amazing but I was wondering if we should just always do it, no flags? You mentioned memory usage but did you confirm it's actually worse? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
parallel_collectparameter to_parse_sql_queries_polarsand_execute_sql_queries_polarsthat usespl.collect_all()to collect all lazy frames in parallel before concatenation.