Validate key mismatches at the write-side#57
Closed
shahbaz-humeai wants to merge 3 commits into
Closed
Conversation
Enforce the hard invariant (all artifacts must share the same __key__ values) at write time, not just read time. When reference_keys is provided to WSSink, each sample's __key__ is validated against the expected key at that offset. Raises KeyMismatchError (per-sample) or SampleCountMismatchError (on close) as fatal BaseExceptions that prevent corrupt shards from being written.
Replace the reference_keys parameter on WSSink with validate_keys=True, which mirrors the read side: automatically finds the smallest sibling shard (by file size, skipping .wsds-link/.wsds-computed), reads its __key__ column, and validates each written sample against it. This matches how list_all_columns() sorts __key__ sources by ascending file size to avoid loading heavy artifacts like audio.
Merge main's WSSink improvements (schema parameter, encode_value in write(), better error truncation) with our write-time key validation. Key validation runs before encode_value so it checks the raw sample.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.