Use UTC time for date handling to ensure consistency across time zones#16
Open
RyanMorash wants to merge 4 commits intoHugoBDesigner:mainfrom
Open
Use UTC time for date handling to ensure consistency across time zones#16RyanMorash wants to merge 4 commits intoHugoBDesigner:mainfrom
RyanMorash wants to merge 4 commits intoHugoBDesigner:mainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request standardizes date and time handling to use UTC across the application to ensure consistent behavior for all users regardless of their time zone. This addresses daily game logic, timer functionality, and word selection to prevent discrepancies between users in different time zones.
- Converted date initialization and calculations from local time to UTC
- Updated game timer logic to use UTC date incrementing
- Modified practice mode word selection to use UTC-based random seeding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the date and time handling in
script.jsto consistently use UTC instead of local time. This ensures that daily game logic and word selection are consistent for all users, regardless of their timezone. The most important changes are:Resolves issue #15
Consistent UTC Date Handling:
firstgameMillito useDate.UTCfor a timezone-independent epoch.getGameNumberandgetAbsoluteDateto use UTC-based setters (setUTCHours,setUTCMinutes, etc.) instead of local time setters. [1] [2]setUTCDateinstead ofsetDate.Word Selection Consistency:
getWordOfTheDay, updated the random seed for practice mode to use the UTC date, ensuring the same word is selected regardless of the user's local time.