Skip to content

Yyakhnytsia/implement missing block kit blocks - #483

Merged
yyakhnytsia merged 7 commits into
HubSpot:masterfrom
yyakhnytsia:yyakhnytsia/implement-missing-block-kit-blocks
Oct 9, 2026
Merged

yyakhnytsia merged 7 commits into
HubSpot:masterfrom
yyakhnytsia:yyakhnytsia/implement-missing-block-kit-blocks

Conversation

@yyakhnytsia

Copy link
Copy Markdown
Contributor

Implement missing Block Kit blocks: https://docs.slack.dev/reference/block-kit/blocks/ to have a full set of elements.
Add missing unit tests.

@opaliukh

opaliukh commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Three things to check before merging:

  1. Video limits are off by one. title and description use length() < 200 (VideoBlockIF.java:58, :68), but Slack allows up to 200 characters. It should be <= 200. Please add a test at exactly 200.

  2. WorkflowButton now validates. The new @check (WorkflowButtonIF.java:45) throws on markdown text or text over 75 characters, including when deserializing Slack messages. That changes an existing class, and the PR description doesn’t mention it. Is that intended, or should it be a separate PR?

  3. Plan tasks may send an extra type. Each task serializes as "type":"task_card" (PlanIF.java:30). Slack’s docs say task objects have no type field. Can we check this against the real API? If Slack rejects it, Plan needs its own task type.

@yyakhnytsia

Copy link
Copy Markdown
Contributor Author

@opaliukh

  1. Fixed
  2. Add missing test, since we've added WorkflowButton in our previous PR no one could use it, because this code haven't been released yet.
  3. Fixed.

@yyakhnytsia
yyakhnytsia merged commit 9bb5ceb into HubSpot:master Oct 9, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants