Skip to content

Yyakhnytsia/implement missing block kit elements - #482

Merged
yyakhnytsia merged 11 commits into
HubSpot:masterfrom
yyakhnytsia:yyakhnytsia/implement-missing-block-kit-elements
Oct 7, 2026
Merged

yyakhnytsia merged 11 commits into
HubSpot:masterfrom
yyakhnytsia:yyakhnytsia/implement-missing-block-kit-elements

Conversation

@yyakhnytsia

Copy link
Copy Markdown
Contributor

Implement missing elements form the Slack block-kit. Add tests to test the post message with the given payload using real api call with bot token and channel id

@opaliukh

opaliukh commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Three notes:

  1. Delete WorkflowIF + WorkflowTriggerIF (dead duplicates). They re-model the same objects as WorkflowObjectIF/TriggerObjectIF, which is what WorkflowButton actually uses — nothing references Workflow. Slack only defines a workflow object + trigger object anyway.
  2. Nit: TriggerObjectIF returns ImmutableList<...> — prefer List<...> to match the other models.
  3. Nit: @JsonProperty("is_skill_invocation") / @JsonProperty("is_slack_url") are redundant; SnakeCaseStrategy already derives those names.

@yyakhnytsia

Copy link
Copy Markdown
Contributor Author

@opaliukh Good catch, fixed.

@yyakhnytsia
yyakhnytsia requested a review from opaliukh October 7, 2026 06:09
@yyakhnytsia

Copy link
Copy Markdown
Contributor Author

@opaliukh can you take another look at it?

@yyakhnytsia
yyakhnytsia merged commit 0b9f2ac into HubSpot:master Oct 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants