Skip to content

bump-packages: support tap-qualified package names#873

Open
chenrui333 wants to merge 3 commits into
mainfrom
bump-packages-full-name
Open

bump-packages: support tap-qualified package names#873
chenrui333 wants to merge 3 commits into
mainfrom
bump-packages-full-name

Conversation

@chenrui333

@chenrui333 chenrui333 commented Jun 19, 2026

Copy link
Copy Markdown
Member

Summary:

  • Auto-enable --full-name for formula and cask names containing /.
  • Keep full-name: true as an explicit override for short names.
  • Update docs and tests for both command paths.

Signed-off-by: Rui Chen <rui@chenrui.dev>
Copilot AI review requested due to automatic review settings June 19, 2026 13:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support to the bump-packages composite action for passing fully-qualified package names through to brew bump via a new full-name input, with documentation and test coverage to ensure both formulae and casks paths behave as expected.

Changes:

  • Introduces a new full-name action input (default false).
  • Updates both “Bump formulae” and “Bump casks” steps to conditionally add --full-name to brew bump when enabled.
  • Documents the new input in the README usage snippet and adds tests covering the --full-name argument for both code paths.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
bump-packages/README.md Documents the new full-name input in the example workflow usage.
bump-packages/action.yml Adds full-name input and conditionally appends --full-name to the brew bump invocation for formulae and casks.
bump-packages/action.test.mts Adds unit tests validating --full-name is passed for fully-qualified formulae and casks.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@carlocab carlocab left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine; optional nit.

Comment thread bump-packages/action.yml Outdated

@MikeMcQuaid MikeMcQuaid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Main question: what would be downsides of making full-name the default behaviour or at least automatic if e.g. a name contains /?

chenrui333 and others added 2 commits June 19, 2026 17:16
Co-authored-by: Carlo Cabrera <github@carlo.cab>
Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333

chenrui333 commented Jun 19, 2026

Copy link
Copy Markdown
Member Author

Yeah, I think we turn on the auto detection behavior, just pushed a change to auto-enable --full-name when package names contain /, which should save action config while preserving existing short-name behavior.

@chenrui333 chenrui333 changed the title bump-packages: support full package names bump-packages: support tap-qualified package names Jun 19, 2026

@MikeMcQuaid MikeMcQuaid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One more tweak

Comment thread bump-packages/action.yml
Comment on lines +23 to +26
full-name:
description: Force fully-qualified package names to brew bump
required: false
default: 'false'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is now auto-detected: do we need this option/input at all?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants