bump-packages: support tap-qualified package names#873
Conversation
Signed-off-by: Rui Chen <rui@chenrui.dev>
There was a problem hiding this comment.
Pull request overview
Adds support to the bump-packages composite action for passing fully-qualified package names through to brew bump via a new full-name input, with documentation and test coverage to ensure both formulae and casks paths behave as expected.
Changes:
- Introduces a new
full-nameaction input (defaultfalse). - Updates both “Bump formulae” and “Bump casks” steps to conditionally add
--full-nametobrew bumpwhen enabled. - Documents the new input in the README usage snippet and adds tests covering the
--full-nameargument for both code paths.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| bump-packages/README.md | Documents the new full-name input in the example workflow usage. |
| bump-packages/action.yml | Adds full-name input and conditionally appends --full-name to the brew bump invocation for formulae and casks. |
| bump-packages/action.test.mts | Adds unit tests validating --full-name is passed for fully-qualified formulae and casks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Looks good! Main question: what would be downsides of making full-name the default behaviour or at least automatic if e.g. a name contains /?
Co-authored-by: Carlo Cabrera <github@carlo.cab>
Signed-off-by: Rui Chen <rui@chenrui.dev>
|
Yeah, I think we turn on the auto detection behavior, just pushed a change to auto-enable |
| full-name: | ||
| description: Force fully-qualified package names to brew bump | ||
| required: false | ||
| default: 'false' |
There was a problem hiding this comment.
If this is now auto-detected: do we need this option/input at all?
Summary:
--full-namefor formula and cask names containing/.full-name: trueas an explicit override for short names.