Reference brew.sh theme assets#436
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the shared-config sync workflow/script so downstream Jekyll sites stop copying brew.sh theme asset files (CSS/images) and instead reference the canonical https://brew.sh/assets/... URLs, while syncing only the shared layouts/includes they actually use.
Changes:
- Remove
brew.shtheme asset directories (_sass,assets/css,assets/img) from the workflow sparse-checkout. - In the sync script, infer the specific shared
_layouts/_includesfiles required by each consuming site and only sync those. - Rewrite synced theme references (and relevant
_config.ymlimage paths) from{{ "/assets/..." | relative_url }}//assets/img/...to canonicalhttps://brew.sh/assets/...URLs, and remove now-obsolete copied asset paths in consuming repos.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/sync-shared-config.yml |
Stops checking out brew.sh theme asset directories since consumers should use canonical asset URLs. |
.github/actions/sync/shared-config.rb |
Infers required shared layouts/includes to sync, removes obsolete copied assets, and rewrites asset references to https://brew.sh. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MikeMcQuaid
force-pushed
the
sync-brewsh-theme
branch
2 times, most recently
from
fdb82ac to
ed96218
Compare
- Keep shared image assets in `brew.sh` instead of copying them to docs sites. - Rewrite synced theme references so consumers use the canonical asset URLs. - Infer the shared layouts and includes each consuming site actually uses. - Infer obsolete shared asset paths at sync time instead of hardcoding them. - Rewrite shared image front matter to avoid broken local metadata URLs. - Avoid syncing feed references to sites without posts.
MikeMcQuaid
force-pushed
the
sync-brewsh-theme
branch
from
ed96218 to
f424f17
Compare
ZhongRuoyu
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew.shinstead of copying them to docs sites.