Add a new rigid registration algorithm RigidGridStart that initialize…#44
Open
Cody-G wants to merge 1 commit into
Open
Add a new rigid registration algorithm RigidGridStart that initialize…#44Cody-G wants to merge 1 commit into
Cody-G wants to merge 1 commit into
Conversation
…s with a gridsearch of rotations+shifts.
Author
|
I was torn about whether to add a feature to the existing |
timholy
reviewed
Jan 6, 2018
Member
timholy
left a comment
There was a problem hiding this comment.
I think it's better as a separate algorithm. Nice work!
| """ | ||
| `RigidGridStart(fixed, maxradians, rgridsz, mxshift; thresh_fac=(0.5)^ndims(fixed), thresh=nothing, SD = eye(ndims(fixed)), pid=1, kwargs...)` | ||
| initializes the `RigidGridStart` registration algorithm. This algorithm works much like `Rigid` except that instead of initializing with a | ||
| principle axis transformation it intializes with a grid search of rotations+shifts. Possible shifts are specified by `mxshift` while rotations |
Author
|
It seems the build is failing because it can't build CUDArt. I didn't change anything related to CUDArt in this PR. My memory may be incorrect but I believe in the past we intelligently skipped building CUDArt when building on Travis. Any idea what's changed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s with a gridsearch of rotations+shifts.
Requires HolyLab/BlockRegistration.jl#73