bug-fix(search): bundle Everything SDK DLL - #20
Closed
EriaWalker wants to merge 1 commit into
Closed
Conversation
Owner
|
Merged and shipped in V2.10.3. GitHub shows this as closed rather than merged because it went in as a squash on Thanks for finding this one. I verified it independently before merging: pulled Three things I added on top:
One note for #21: it branches off this work, and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundle the Everything SDK DLL
Summary
This change bundles the x64
Everything64.dllwith the Windows application.The application uses the bundled DLL before it starts Everything search.
The application does not download an SDK DLL at runtime.
Cause
The old code downloaded
Everything-SDK.zipfrom a mutable URL.The code compared the downloaded DLL with an old fixed SHA-256 value.
Voidtools changed the DLL in the archive.
The hash check then rejected the official DLL.
Current Installation is Invalid.
Changes
ThirdParty/EverythingSdk.81B5BE18126ACD2C2B913F8F4A821E476B18393CDD3DEBD03387C50AFD8DB88F.Code Changes
EasyExtractCrossPlatform.csprojnow treatsEverything64.dllas publish content.EverythingSdkBootstrappernow uses the bundled DLL before it starts Everything search.Everything64.dllnow matches the bundled DLL..gitignoreallows Git to track this one third-party DLL.Verification
dotnet test EasyExtractUnitypackageRework/EasyExtractCrossPlatform.Tests/EasyExtractCrossPlatform.Tests.csproj --configuration Release --no-builddotnet publish EasyExtractUnitypackageRework/EasyExtractCrossPlatform/EasyExtractCrossPlatform.csproj --configuration Release --runtime win-x64 --self-contained.nupkgincludeEverything64.dllwith the pinned hash.Notes
The DLL comes from the Voidtools Everything SDK archive verified on 2026-08-22.
The DLL size is 89.2 KB.