DMYTRO_DORONIN-w3-JavaScript#10
DMYTRO_DORONIN-w3-JavaScript#10Dmytro-Doronin wants to merge 2 commits intoHackYourAssignment:mainfrom
Conversation
|
Hi Dmytro 👋 Good job completing all the exercises for Week 3. I can see you’ve worked through each one carefully. Here’s my feedback: ✅ What you did well ex1: Nice refactor using filter + map. Much cleaner than the loop. ex2: Correct use of reduce, and returning the formatted euro amount is a good touch. ex3: The function works well and keeps the original array unchanged — good! ex4: subscribe and notify are implemented correctly, and tests pass. ex5: Quiz answers are filled in and all tests pass. 💡 Things to improve Be careful with naming variables (e.g., e vs employee) so the code is easier to read. In ex2, .toFixed(2) returns a string. That’s fine for formatting, but keep in mind it changes the type. Remember to remove debug console.log once you are done testing (like in transferInto). When working with functions, think about edge cases (what if no input is given, or the array is empty?). General advice Keep practicing with map, filter, and reduce — you’re using them well already. Write code that’s clear first, then think about making it shorter. Overall, very nice progress 👏. You’ve shown good understanding of arrays, functions, and objects this week. Keep going, you’re improving step by step 🚀 Latif |
|
Thanks a lot for your detailed feedback 🙏 It really helps me see where I can improve. I’ll pay more attention to naming and edge cases in the future. I also appreciate your encouragement — it motivates me to keep goingю. |
No description provided.