Skip to content

Conversation

@Glavo
Copy link
Member

@Glavo Glavo commented Jan 23, 2026

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes issue #5280 where horizontal scrollbars were appearing on some list pages. The fix involves adding CSS to hide horizontal scrollbars and refactoring duplicate cell width limiting code into a reusable utility method.

Changes:

  • Added CSS class .no-horizontal-scrollbar to hide horizontal scrollbars on specific list views
  • Created new utility method FXUtils.limitCellWidth() to consolidate duplicate code for binding cell widths to container widths
  • Cleaned up redundant fully qualified class names in favor of shorter imported names

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
HMCL/src/main/resources/assets/css/root.css Adds .no-horizontal-scrollbar CSS class to hide horizontal scrollbars; minor formatting fixes for toggle button styles
HMCL/src/main/java/org/jackhuang/hmcl/ui/FXUtils.java Adds limitCellWidth() utility method; adds Desktop import; removes redundant fully qualified class names
HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/DownloadListPage.java Refactors to use new limitCellWidth() method instead of inline width binding code
HMCL/src/main/java/org/jackhuang/hmcl/ui/main/JavaManagementPage.java Applies no-horizontal-scrollbar CSS class; refactors to use limitCellWidth() method; updates constructor to pass listView reference

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Glavo Glavo merged commit d2ae41c into HMCL-dev:main Jan 27, 2026
2 checks passed
@Glavo Glavo deleted the limit-width branch January 27, 2026 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant