Add extra path to HDF5_PLUGIN_PATH for Windows binary testing#227
Merged
lrknox merged 1 commit intoHDFGroup:masterfrom Feb 27, 2026
Merged
Add extra path to HDF5_PLUGIN_PATH for Windows binary testing#227lrknox merged 1 commit intoHDFGroup:masterfrom
lrknox merged 1 commit intoHDFGroup:masterfrom
Conversation
jhendersonHDF
force-pushed
the
win_testing_plugin_path
branch
from
371bda7 to
6c662fc
Compare
brtnfld
approved these changes
Feb 27, 2026
Contributor
Author
|
Binary testing in https://github.com/HDFGroup/hdf5_plugins/actions/runs/22501444922 failed due to the missing plugin path |
lrknox
approved these changes
Feb 27, 2026
jhendersonHDF
added a commit
to jhendersonHDF/hdf5_plugins
that referenced
this pull request
Feb 27, 2026
lrknox
pushed a commit
that referenced
this pull request
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for ZFP testing currently as all plugins except for ZFP get installed under
ROOT\lib\pluginon Windows, whereas ZFP goes underROOT\plugin.Important
Adds an extra path to
HDF5_PLUGIN_PATHinCMakeLists.txtfor Windows to support ZFP testing._plugin_pathfor Windows inCMakeLists.txtto includeROOT/pluginfor ZFP testing.ROOT/lib/pluginandROOT/pluginare checked for plugins on Windows.H5PL_BUILD_TESTINGsection to ensure ZFP plugin is found during tests.This description was created by
for 371bda7. You can customize this summary. It will automatically update as commits are pushed.