Various fixes to handling of chunk buffers#6184
Draft
fortnern wants to merge 7 commits intoHDFGroup:developfrom
Draft
Various fixes to handling of chunk buffers#6184fortnern wants to merge 7 commits intoHDFGroup:developfrom
fortnern wants to merge 7 commits intoHDFGroup:developfrom
Conversation
size checks in H5D__chunk_lock and H5Z_pipeline
Member
Author
|
Not scheduled for 2.1.0. Needs a test and doc updates to clarify the expected behavior of filters |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Verify uncompressed chunks are the right size after being uncompressed (reverse filtered)
Verify that the buffer returned from the filter callback is large enough to hold the returned data size
Fix bug in deflate filter that caused it to report the wrong buffer size
Fix bug in chunk copy code that could cause a background buffer overflow
Other general cleanup
The verification of the size of chunks after decompression causes a failure in NetCDF. I suspect this is an issue in that NetCDF test.
Important
Fixes and enhancements to chunk buffer handling, including size verification and buffer overflow prevention in
H5Dchunk.c,H5Z.c, andH5Zdeflate.c.H5Dchunk.c, verify uncompressed chunk size inH5D__chunk_lock()andH5D__chunk_copy_cb().H5Z.c, ensure buffer size is sufficient after filter callback inH5Z_pipeline().H5D__chunk_copy_cb()by ensuring background buffer size is adequate.H5Z__filter_deflate()inH5Zdeflate.c.bkg_sizeandsrc_chunk_sizetoH5D_chunk_it_ud3_tinH5Dchunk.c.H5Dchunk.candH5Z.c.This description was created by
for 7788329. You can customize this summary. It will automatically update as commits are pushed.