Repository navigation
Support local scopes on injected dependencies - #77
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Core cache-separation and scope-wrapping guarantees are not conclusively tested.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Adds validation for consumer-local dependency scopes and test-time SPI registration.
Changes:
- Tests constructor, field, custom, lifecycle, and error semantics.
- Registers test scope SPIs through
ServiceLoader.
| File | Description |
|---|---|
LocalScopeTest.java |
Exercises local-scope behavior. |
...ScopeAnnotationProvider |
Registers the test marker provider. |
...BindScopeProvider |
Registers the test scope binder. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Consumers can now apply a scope to an injectable constructor parameter or field without changing the dependency's binding for other consumers. This ports the core behavior proposed in google/guice#1949 to GuicedEE's shaded Guice source.
The scoped provider is shared by the same consumer, scope annotation, and dependency key. Other consumers remain isolated, and a locally scoped dependency wraps any scope already configured on its binding. Scope recognition and binding continue through the existing
ScopeAnnotationProviderandBindScopeProviderSPIs.The README documents local scope semantics and walks through registering
@RequestScoped, including a minimal synchronous scope implementation, service registration, and request entry/exit. No web runtime dependency is added to guice-core.Validation:
mvn -q testinGoogle/guice-coreon this branch (8 tests, 0 failures).