fix: resolve seller name null on cross-server purchase#27
Merged
Conversation
Prevent IllegalArgumentException: name cannot be null when a buyer on one server purchases an item from a seller who has never logged into that specific backend node. Before calling the economy provider, the seller name is now resolved via the shared database (storageManager.getPlayerName) as a fallback, ensuring no null is passed downstream.
There was a problem hiding this comment.
Pull request overview
Fixes cross-server purchase failures where AuctionItem#getSellerName() can be null on a backend node the seller never joined, by resolving a non-null seller identifier before invoking the economy provider and messaging.
Changes:
- Add a fallback seller-name resolution using
storageManager.getPlayerName(UUID)when the in-memory seller name is missing. - Use the resolved seller name in withdraw reason and purchase messages to prevent null from flowing downstream.
- Add log output when a missing seller name is resolved (or cannot be resolved and falls back to UUID).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+764
to
+767
| String resolvedSellerName = auctionItem.getSellerName(); | ||
| if (resolvedSellerName == null) { | ||
| resolvedSellerName = storageManager.getPlayerName(auctionItem.getSellerUniqueId()); | ||
| if (resolvedSellerName != null) { |
| + auctionItem.getSellerUniqueId() + " -> " + resolvedSellerName | ||
| + " (cross-server purchase, item " + auctionItem.getId() + ")"); | ||
| } else { | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent IllegalArgumentException: name cannot be null when a buyer on one server purchases an item from a seller who has never logged into that specific backend node. Before calling the economy provider, the seller name is now resolved via the shared database (storageManager.getPlayerName) as a fallback, ensuring no null is passed downstream.