Fix: CAPITALISM tax & transaction error handling bugs#24
Merged
Conversation
…g, fix stuck item status
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Balance check fixes
PurchaseService&ListedItemsButton: CAPITALISM tax now included inpre-purchase balance check (was checking base price only, allowing
buyers who couldn't afford price+tax to pass)
PurchaseService: item status now restored fromIS_BEING_PURCHASEDto previous status on insufficient funds, preventing items from
becoming permanently unclickable in the UI
Transaction error handling (ZAuctionManager)
withdraw()wrapped in try-catch; throws on failure to abortthe purchase via existing CompletableFuture exception handler
deposit()to seller wrapped in try-catch with automatic buyerrefund on failure
beforefield corrected for deferred deposits(was
balance - amounteven when no deposit occurred)Claim service fixes
runAsyncfor deposits; now synchronousbefore marking transactions as
RETRIEVED, preventing money losson server crash