Skip to content

Convert custom data classes to enum configs#904

Merged
GregHib merged 32 commits intomainfrom
enum-data
Mar 1, 2026
Merged

Convert custom data classes to enum configs#904
GregHib merged 32 commits intomainfrom
enum-data

Conversation

@GregHib
Copy link
Owner

@GregHib GregHib commented Mar 1, 2026

Closes #902

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2026

Qodana for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@codecov
Copy link

codecov bot commented Mar 1, 2026

Codecov Report

❌ Patch coverage is 47.90576% with 199 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.75%. Comparing base (72845b9) to head (fd9fbee).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../src/main/kotlin/content/skill/crafting/Weaving.kt 0.00% 18 Missing ⚠️
...ain/kotlin/content/skill/crafting/SilverCasting.kt 0.00% 17 Missing ⚠️
...s/voidps/engine/data/definition/EnumDefinitions.kt 0.00% 16 Missing ⚠️
.../src/main/kotlin/content/skill/smithing/Furnace.kt 60.00% 6 Missing and 10 partials ⚠️
...ame/src/main/kotlin/content/skill/mining/Mining.kt 70.45% 3 Missing and 10 partials ⚠️
...ain/kotlin/content/skill/crafting/SpinningWheel.kt 0.00% 12 Missing ⚠️
...e/src/main/kotlin/content/skill/fishing/Fishing.kt 61.53% 2 Missing and 8 partials ⚠️
.../src/main/kotlin/content/skill/crafting/Pottery.kt 0.00% 9 Missing ⚠️
...ain/kotlin/content/skill/firemaking/LightSource.kt 0.00% 9 Missing ⚠️
game/src/main/kotlin/content/entity/obj/Picking.kt 0.00% 8 Missing ⚠️
... and 23 more
Additional details and impacted files
Files with missing lines Coverage Δ
...s/voidps/engine/data/definition/ItemDefinitions.kt 42.68% <ø> (+8.02%) ⬆️
...gs/voidps/engine/data/definition/NPCDefinitions.kt 67.92% <ø> (+2.46%) ⬆️
...t/area/misthalin/lumbridge/swamp/LumbridgeSwamp.kt 7.14% <ø> (ø)
game/src/main/kotlin/Main.kt 0.00% <0.00%> (ø)
...lin/content/activity/shooting_star/ShootingStar.kt 10.07% <0.00%> (+0.07%) ⬆️
...tlin/content/area/kandarin/ourania/OuraniaAltar.kt 69.23% <75.00%> (+0.80%) ⬆️
...n/content/area/kharidian_desert/al_kharid/Ellis.kt 25.80% <66.66%> (+1.21%) ⬆️
...rc/main/kotlin/content/skill/crafting/Jewellery.kt 77.77% <85.71%> (+0.35%) ⬆️
.../main/kotlin/content/skill/smithing/Cannonballs.kt 7.89% <0.00%> (ø)
...egs/voidps/cache/definition/data/EnumDefinition.kt 63.15% <0.00%> (-7.44%) ⬇️
... and 26 more

... and 1 file with indirect coverage changes

@@             Coverage Diff              @@
##               main     #904      +/-   ##
============================================
+ Coverage     37.34%   37.75%   +0.40%     
- Complexity     7586     7590       +4     
============================================
  Files          1585     1560      -25     
  Lines         62252    61795     -457     
  Branches      15751    15681      -70     
============================================
+ Hits          23248    23330      +82     
+ Misses        33791    33248     -543     
- Partials       5213     5217       +4     
Components Coverage Δ
Content 35.12% <51.12%> (+0.11%) ⬆️
Engine 44.74% <9.09%> (+2.28%) ⬆️
Network 60.85% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GregHib GregHib merged commit 9c51823 into main Mar 1, 2026
5 checks passed
@GregHib GregHib deleted the enum-data branch March 1, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Convert existing excess config data to custom enums

1 participant