Error message hard to read #938#985
Error message hard to read #938#985abdullah-maher-abbod wants to merge 2 commits intoGreenstand:masterfrom
Conversation
EngrTaofeek
left a comment
EngrTaofeek
left a comment
There was a problem hiding this comment.
Generally when making changes to the user interface you could add a screenshot or screen recording of the effect of the change
| private val languageSwitcher: LanguageSwitcher by inject() | ||
| private val viewModelFactory: TreeTrackerViewModelFactory by inject() | ||
|
|
||
| //hello this is the first change i have made |
There was a problem hiding this comment.
No need to add this comment. Github automatically the lines and file you made changes to.
There was a problem hiding this comment.
Yeah this was on the first commit, i was trying learn how deal with github.
| text = data.message, | ||
| style = CustomTheme.typography.regular, | ||
| color = CustomTheme.textColors.darkText | ||
| color = CustomTheme.textColors.lightText |
|
I'm not sure this issue was talking about the button text. I think it was referring to the black error text showing in the red box. I think this should be decided by design before committing to a change though. @EngrTaofeek can you confirm with design on this task please? |
|
@Elforama Yes, this changing the black error text in the red box as it shown below:
|
3 participants
Fixes #938
-Change the Text color to White
-add an example for the User