Conversation
Aligned ElectricPowerQualitySummaryEntity field order with ESPI 4.0 XSD schema specification (espi.xsd). Moved summaryInterval field to correct position between shortInterruptions and supplyVoltageDips to match schema sequence. Changes: - ElectricPowerQualitySummaryEntity: Reordered summaryInterval field to match XSD element sequence (lines 121-139) - V3__Create_additiional_Base_Tables.sql: Updated table column order to match XSD schema (summary_interval columns now between short_interruptions and supply_voltage_dips) Validation: - ElectricPowerQualitySummaryDto already compliant with XSD propOrder - ElectricPowerQualitySummaryMapper uses default MapStruct field mapping - All repository queries preserved for test usage - All 533 tests passing (unit + integration with H2, MySQL, PostgreSQL) Schema Element Order (ESPI 4.0 espi.xsd): 1. flickerPlt 2. flickerPst 3. harmonicVoltage 4. longInterruptions 5. mainsVoltage 6. measurementProtocol 7. powerFrequency 8. rapidVoltageChanges 9. shortInterruptions 10. summaryInterval (DateTimeInterval - REQUIRED) 11. supplyVoltageDips 12. supplyVoltageImbalance 13. supplyVoltageVariations 14. tempOvervoltage References: - ESPI 4.0 XSD: espi.xsd ElectricPowerQualitySummary complexType - Phase plan: Issue #28 Phase 12 - Related: Phase 11 (UsageSummary) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dfcoffin
deleted the
feature/schema-compliance-phase-12-electric-power-quality-summary
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 12 of the ESPI 4.0 schema compliance effort. This PR aligns the
ElectricPowerQualitySummaryEntityfield order with the ESPI 4.0 XSD schema specification (espi.xsd).Changes
Entity Updates
summaryIntervalfield from end of field declarations to correct position betweenshortInterruptionsandsupplyVoltageDipsto match XSD element sequenceDatabase Migration Updates
electric_power_quality_summariestable column order to match XSD schema:summary_interval_startandsummary_interval_durationcolumns to position aftershort_interruptionsand beforesupply_voltage_dipsVerified Components (No Changes Needed)
@XmlType propOrderESPI 4.0 XSD Schema Element Sequence
Per
espi.xsdElectricPowerQualitySummary complexType:Testing
✅ All 533 tests passing
Unit Tests
Integration Tests (TestContainers)
Test Coverage
Related Work
Checklist
@XmlType propOrderverified correct🤖 Generated with Claude Code