-
Notifications
You must be signed in to change notification settings - Fork 1
feat: issue 23, issue #58, issue #57 #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dfcoffin
merged 9 commits into
GreenButtonAlliance:main
from
springframeworkguru:feat-issue-23-update-atom-props
Jan 2, 2026
Merged
feat: issue 23, issue #58, issue #57 #59
dfcoffin
merged 9 commits into
GreenButtonAlliance:main
from
springframeworkguru:feat-issue-23-update-atom-props
Jan 2, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se flyway for migrations
This was referenced Jan 2, 2026
dfcoffin
added a commit
that referenced
this pull request
Jan 4, 2026
…approach chosen in PR #59: using Jackson 3 as the XML serialization engine while retaining JAXB annotations on DTOs. Changes: - MULTI_PHASE_SCHEMA_COMPLIANCE_PLAN.md: Updated technology stack, DTO marshalling approach, and test requirements to document Jackson 3 with JAXB annotations (via jackson-module-jakarta-xmlbind-annotations) - DTO_APPROACH_COMPARISON.md: Added 'DECISION MADE' status, comprehensive rationale section, and implementation details from PR #59 - PR50_MULTI_PHASE_IMPACT.md: Added resolution section documenting the final decision and updated documentation references The hybrid approach combines: - Jackson 3 XmlMapper (tools.jackson.dataformat:jackson-dataformat-xml:3.0.3) - JAXB annotations (jakarta.xml.bind.annotation.*) - Bridge module (jackson-module-jakarta-xmlbind-annotations:3.0.3) This provides Jackson 3's modern performance with JAXB's proven XML schema compliance, requiring zero annotation rewrites. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>"
4 tasks
dfcoffin
added a commit
that referenced
this pull request
Jan 4, 2026
…approach (#60) chosen in PR #59: using Jackson 3 as the XML serialization engine while retaining JAXB annotations on DTOs. Changes: - MULTI_PHASE_SCHEMA_COMPLIANCE_PLAN.md: Updated technology stack, DTO marshalling approach, and test requirements to document Jackson 3 with JAXB annotations (via jackson-module-jakarta-xmlbind-annotations) - DTO_APPROACH_COMPARISON.md: Added 'DECISION MADE' status, comprehensive rationale section, and implementation details from PR #59 - PR50_MULTI_PHASE_IMPACT.md: Added resolution section documenting the final decision and updated documentation references The hybrid approach combines: - Jackson 3 XmlMapper (tools.jackson.dataformat:jackson-dataformat-xml:3.0.3) - JAXB annotations (jakarta.xml.bind.annotation.*) - Bridge module (jackson-module-jakarta-xmlbind-annotations:3.0.3) This provides Jackson 3's modern performance with JAXB's proven XML schema compliance, requiring zero annotation rewrites. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several important updates to the Green Button ESPI codebase, primarily focused on improving XML/JSON serialization compatibility, updating entity mappings for UUIDs, and cleaning up CI configuration. The changes modernize how resources are represented in Atom feeds, enhance database compatibility for UUID fields, and streamline the CI pipeline by removing legacy service dependencies.
Serialization and DTO Improvements
AtomEntryDtoandAtomContentDtoto support direct serialization of Green Button resources (such asUsagePointDto,MeterReadingDto, andReadingTypeDto) with Jackson XML annotations. DeprecatedAtomContentDtoand moved payload handling toAtomEntryDto, enabling better interoperability and future extensibility. [1] [2] [3] [4] [5]IntervalBlockDto,IntervalReadingDto,ReadingTypeDto,UsagePointDto) to clean up or replace JAXB annotations, add Jackson annotations, and introduce namespace handling for ESPI resources. [1] [2] [3] [4] [5] [6] [7]Database Entity Mapping
PhoneNumberEntity,StatementRefEntity,AggregatedNodeRefEntity,BatchListEntity,IntervalReadingEntity,LineItemEntity,ReadingQualityEntity) to use Hibernate’s@JdbcTypeCode(SqlTypes.CHAR)for UUID fields, ensuring consistent storage aschar(36)and improving cross-database compatibility. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]Dependency Management
openespi-common/pom.xmlto support new serialization features alongside Jakarta XML Bind.CI/CD Pipeline Cleanup
These updates collectively improve code maintainability, serialization robustness, and CI efficiency.