fix: Ensure that the SqlDataEndpoint includes the default port :443 - #1148
Merged
Conversation
hessjcg
force-pushed
the
postgres-aide-e2e
branch
3 times, most recently
from
August 15, 2026 17:49
25efd4f to
668e4e4
Compare
hessjcg
changed the title
hessjcg
changed the title
hessjcg
marked this pull request as ready for review
August 15, 2026 17:55
hessjcg
force-pushed
the
postgres-aide-e2e
branch
4 times, most recently
from
August 17, 2026 17:35
221e3da to
16fa8ca
Compare
…iptype - Add TestPostgresSQLDataConnect for direct AIDE SQLData connection - Add TestPostgresSQLDataFallback for fallback from SQLData to direct IP on PreconditionFailed - Support SQLData fallback IP address preference order: PRIVATE, PSC, PUBLIC in ConnectionInfo - Add TestConnectInfoSQLDataFallbackIP unit tests covering IP preference order - Configure GAPIC SqlDataClient option initialization and streaming buffer handling - Update write_e2e_env and build.sh to auto-detect GITHUB_TOKEN via gh CLI - Update write_e2e_env and .github/workflows/tests.yaml for POSTGRES_AIDE_* and POSTGRES_FALLBACK_* secrets
hessjcg
changed the title
kgala2
approved these changes
Aug 17, 2026
hessjcg
force-pushed
the
postgres-aide-e2e
branch
from
August 17, 2026 20:42
16fa8ca to
0c3159d
Compare
hessjcg
enabled auto-merge (squash)
August 17, 2026 20:43
hessjcg
added a commit
to GoogleCloudPlatform/cloud-sql-proxy
that referenced
this pull request
Aug 17, 2026
This incorporates the fix in GoogleCloudPlatform/cloud-sql-go-connector#1148 which was released in go connector v1.25.1
hessjcg
added a commit
to GoogleCloudPlatform/cloud-sql-proxy
that referenced
this pull request
Aug 17, 2026
…2666) This incorporates the fix in GoogleCloudPlatform/cloud-sql-go-connector#1148 which was released in go connector v1.25.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GAPIC client library for SqlDataService requires that the endpoint include the port, for example "sqladmin.googleapis.com:443" This updates the default endpoint string, and adds logic to ensure
that ":443" is automatically added to the config option value if necessary.
The previous implementation using a generated gRPC library did not require the port number, so it worked with "sqladmin.googleapis.com".
Additionally, PR adds an end-to-end test verifying PostgreSQL connectivity via SqlDataService (AIDE) and updates CI and build scripts to manage AIDE secrets.
TestPostgresSQLDataConnectend-to-end integration testwrite_e2e_envinbuild.shto fetchPOSTGRES_AIDE_*secrets from Secret Manager.github/workflows/tests.yamlto fetch and passPOSTGRES_AIDE_*secrets in integration test runs