Use GIX_TEST_FIXTURE_HASH for gix-filter#2495
Merged
Sebastian Thiel (Byron) merged 1 commit intoGitoxideLabs:mainfrom Apr 6, 2026
Merged
Use GIX_TEST_FIXTURE_HASH for gix-filter#2495Sebastian Thiel (Byron) merged 1 commit intoGitoxideLabs:mainfrom
GIX_TEST_FIXTURE_HASH for gix-filter#2495Sebastian Thiel (Byron) merged 1 commit intoGitoxideLabs:mainfrom
Conversation
Sebastian Thiel (Byron)
approved these changes
Apr 6, 2026
Member
Sebastian Thiel (Byron)
left a comment
Sebastian Thiel (Byron)
left a comment
There was a problem hiding this comment.
Thanks a lot, looks good to me!
And sorry for the late response!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
gix-filtertests for bothSHA1andSHA256tojustfile.Open question
gix-filter/tests/fixtures/generated-archives/pipeline_repos.tarwas already present, but ingix-filter/tests/fixtures/generated-archives/.gitignore, as opposed to/baseline.tarwhich is in.gitignoreand thus not tracked by git. I tried to guess what the expected changes were, but my guess might be wrong. :-)This PR is related to #281.