Skip to content

Remove unneeded direct Dokka dependency#1680

Merged
gpunto merged 2 commits into
developfrom
rm-dokka
May 14, 2026
Merged

Remove unneeded direct Dokka dependency#1680
gpunto merged 2 commits into
developfrom
rm-dokka

Conversation

@gpunto
Copy link
Copy Markdown
Contributor

@gpunto gpunto commented May 13, 2026

Goal

While working on the Dokka v2 bump in our conventions repo, I realized that in here we're still applying Dokka directly. That's not needed, the convention plugins do that already.

Implementation

Remove Dokka plugin from the version catalog and all plugin applications

Testing

Dokka should still work, e.g. ./gradlew dokkaHtmlMultimodule

Summary by CodeRabbit

  • Chores
    • Removed Dokka build tool integration from project build configuration files.

Review Change Stack

@gpunto gpunto added the pr:ignore-for-release Exclude from changelog generation label May 13, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 13, 2026

PR checklist ✅

All required conditions are satisfied:

  • Title length is OK (or ignored by label).
  • At least one pr: label exists.
  • Sections ### Goal, ### Implementation, and ### Testing are filled (or ignored for dependabot PRs).

🎉 Great job! This PR is ready for review.

@gpunto gpunto marked this pull request as ready for review May 13, 2026 08:54
@gpunto gpunto requested a review from a team as a code owner May 13, 2026 08:54
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 0e949c0c-c11f-4ca6-b8be-cea7f9b8becc

📥 Commits

Reviewing files that changed from the base of the PR and between 6e99b02 and a3d27b5.

📒 Files selected for processing (5)
  • build-logic/convention/src/main/kotlin/AndroidLibraryComposeConventionPlugin.kt
  • build-logic/convention/src/main/kotlin/AndroidLibraryConventionPlugin.kt
  • build.gradle.kts
  • gradle/libs.versions.toml
  • stream-video-android-bom/build.gradle.kts
💤 Files with no reviewable changes (5)
  • build-logic/convention/src/main/kotlin/AndroidLibraryComposeConventionPlugin.kt
  • build.gradle.kts
  • stream-video-android-bom/build.gradle.kts
  • build-logic/convention/src/main/kotlin/AndroidLibraryConventionPlugin.kt
  • gradle/libs.versions.toml

Walkthrough

This pull request removes the Dokka documentation generation plugin from the entire build system. The plugin is stripped from the Gradle version catalog and all build scripts and convention plugins that previously applied it.

Changes

Dokka Plugin Removal from Build System

Layer / File(s) Summary
Gradle version catalog cleanup
gradle/libs.versions.toml
Dokka version reference (kotlinDokka) is removed from the [versions] section, and the dokka plugin alias is removed from the [plugins] section.
Build script and convention plugin cleanup
build.gradle.kts, build-logic/convention/src/main/kotlin/AndroidLibraryConventionPlugin.kt, build-logic/convention/src/main/kotlin/AndroidLibraryComposeConventionPlugin.kt, stream-video-android-bom/build.gradle.kts
Dokka plugin applications are removed from the root build script, both Android library convention plugins, and the BOM module build script.

🎯 1 (Trivial) | ⏱️ ~3 minutes

🐰 A rabbit hops through the build so fast,
Dokka's docs are now a thing of the past,
Five files cleaned, not one stone left unturned,
The build compiles lighter—a lesson we've learned!
thump thump

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description includes Goal and Implementation sections but lacks Testing details, UI Changes section, and most contributor/reviewer checklists required by the template. Complete the Testing section with actual test results, add the contributor checklist, and ensure reviewer checklist items are addressed before merge.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and accurately describes the main change: removing unnecessary direct Dokka dependency while convention plugins handle it.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch rm-dokka

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 13, 2026

SDK Size Comparison 📏

SDK Before After Difference Status
stream-video-android-core 12.04 MB 12.04 MB 0.00 MB 🟢
stream-video-android-ui-xml 5.68 MB 5.68 MB 0.00 MB 🟢
stream-video-android-ui-compose 6.28 MB 6.27 MB -0.02 MB 🚀

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@gpunto gpunto merged commit 09cb9c9 into develop May 14, 2026
15 of 17 checks passed
@gpunto gpunto deleted the rm-dokka branch May 14, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:ignore-for-release Exclude from changelog generation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants