Skip to content

[Backport PR #14402 to 5.1.x] Moving the logic of PROFILE_LANGUAGE_CHOICES to a helper function - #14478

Merged
mattiagiupponi merged 2 commits into
5.1.xfrom
backport-14402-to-5.1.x
Jul 30, 2026
Merged

[Backport PR #14402 to 5.1.x] Moving the logic of PROFILE_LANGUAGE_CHOICES to a helper function#14478
mattiagiupponi merged 2 commits into
5.1.xfrom
backport-14402-to-5.1.x

Conversation

@sijandh35

Copy link
Copy Markdown
Contributor

Backport PR: #14402

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot Bot added the cla-signed CLA Bot: community license agreement signed label Jul 30, 2026
@sijandh35
sijandh35 requested a review from mattiagiupponi July 30, 2026 10:57
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@codecov

codecov Bot commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (5.1.x@5c3f187). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff            @@
##             5.1.x   #14478   +/-   ##
========================================
  Coverage         ?   74.89%           
========================================
  Files            ?      985           
  Lines            ?    60895           
  Branches         ?     8347           
========================================
  Hits             ?    45607           
  Misses           ?    13422           
  Partials         ?     1866           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mattiagiupponi
mattiagiupponi merged commit f8e7077 into 5.1.x Jul 30, 2026
14 checks passed
@mattiagiupponi
mattiagiupponi deleted the backport-14402-to-5.1.x branch July 30, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants