[Fixes #14455] XML metadata is not regenerated after updating metadata - #14456
Merged
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses GeoNode issue #14455 by ensuring CSW XML metadata is regenerated after users update resource metadata via the API. It refactors catalogue post-save behavior to centralize the XML/ANYTEXT regeneration logic and explicitly triggers that regeneration after metadata updates.
Changes:
- Extracted CSW XML/ANYTEXT regeneration into a reusable
update_csw_metadata()helper. - Updated
catalogue_post_save()to use the extracted helper during normal catalogue synchronization. - Invoked
update_csw_metadata()after metadata updates in thePUT/PATCH /api/v2/metadata/instance/<pk>/flow.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| geonode/metadata/api/views.py | Calls CSW metadata regeneration after saving updated JSON-schema metadata. |
| geonode/catalogue/models.py | Refactors catalogue post-save to reuse update_csw_metadata() and adjusts link recreation / logging paths. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mattiagiupponi
approved these changes
Jul 23, 2026
This was referenced Jul 23, 2026
Merged
etj
added a commit
that referenced
this pull request
Jul 23, 2026
etj
added a commit
that referenced
this pull request
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14455
catalogue_post_saveto extractupdate_csw_metadataprocedureupdate_csw_metadataafter saving metadata.Preferred this explicit implementation instead of calling
get_real_instancefor triggeringcatalogue_post_saveby signalChecklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.