Add comments to preference lists: per-applicant and group-wide - #179
Merged
Conversation
Mirrors the existing InterviewComment pattern: any group member may post any number of comments, marked with their name, and edit only their own (no delete, matching that precedent). One table with a nullable application_id — absent is a comment on the group as a whole, set is a comment on that one applicant — bundled into the existing detail fetch so opening a list costs one request, not one per entry. Scoped to the shared list only; personal lists don't get comments. Never deadline-gated, since discussion isn't the ranked decision data itself.
✅ Deploy Preview for generate-appportal ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InterviewCommentpattern closely: any group member (or chief/admin) may post any number of comments; only the comment's own author can edit it; no delete (same asInterviewComment— not adding a capability the closest precedent in this codebase doesn't have).preference_list_comments) with a nullableapplication_id: absent means a comment on the group as a whole, set means a comment on that one applicant. Bundled into the existingGetPreferenceListDetailfetch (alongside members/entries/personal_entries) so opening a list costs one request regardless of how many entries or comments it has.Test plan
make fmt-check,make vet,make lint,make test,make openapinpm run generate:api,npx eslint,npx tsc --noEmit,npx prettier --check,npm run test