Skip to content

fix: clean shared links + add copy-link button#59

Merged
GeiserX merged 1 commit into
mainfrom
fix/share-link-tidy
Jun 8, 2026
Merged

fix: clean shared links + add copy-link button#59
GeiserX merged 1 commit into
mainfrom
fix/share-link-tidy

Conversation

@GeiserX

@GeiserX GeiserX commented Jun 8, 2026

Copy link
Copy Markdown
Owner

Summary

Two small follow-ups to the v1.6.0 sharing feature, from live feedback:

  1. Shared links no longer carry redundant text. The route share was sending text: "Pumperly route" and the station share text: "<brand> — <price>". Native share targets prepend the text field to the URL, so shared route links arrived as Pumperly route https://… — the "extra words at the end" the user reported. Now both share { title, url } only (title populates the share-sheet heading without polluting the link).
  2. Added a Copy-link button to the station popup (clipboard icon → checkmark) next to Share, so users can copy the station deep-link directly without going through the native share sheet. copyToClipboard() is now exported from lib/share.ts.
  3. i18n popup.copyLink across all 16 locales.

Test plan

  • tsc clean
  • 530 tests pass (+2 popup tests: action-row buttons + copy-link writes the deep-link)
  • next build ok

- shared links no longer carry a redundant text body: the route share
  dropped `text: "Pumperly route"` and the station share dropped
  `text: "<brand> — <price>"`. Native share targets prepend `text` to the
  URL, which is what appended "Pumperly route " to shared route links.
  Now shares { title, url } only.
- station popup: add a dedicated Copy-link button (clipboard icon → check)
  next to Share that copies the station deep-link directly without opening
  the share sheet. Exposes copyToClipboard() from lib/share.ts.
- i18n: popup.copyLink across all 16 locales.
@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@GeiserX, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 33 minutes and 14 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 619a4fac-eb12-43d7-9191-ca20a9344b48

📥 Commits

Reviewing files that changed from the base of the PR and between 060a91b and 9149f1e.

📒 Files selected for processing (5)
  • src/components/map/station-popup.test.tsx
  • src/components/map/station-popup.tsx
  • src/components/search/search-panel.tsx
  • src/lib/i18n.tsx
  • src/lib/share.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/share-link-tidy

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@GeiserX GeiserX merged commit 5058c9e into main Jun 8, 2026
8 checks passed
@GeiserX GeiserX deleted the fix/share-link-tidy branch June 8, 2026 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant