Skip to content

docs(hytale): fix Java package names and update warning commands - #131

Merged
dgibbs64 merged 2 commits into
masterfrom
docs/hytale-copilot-fixes
Oct 4, 2026
Merged

dgibbs64 merged 2 commits into
masterfrom
docs/hytale-copilot-fixes

Conversation

@dgibbs64

@dgibbs64 dgibbs64 commented Oct 4, 2026

Copy link
Copy Markdown
Member

Follow-up to #130, which was merged before its Copilot review arrived. This fixes both findings:

  • Java package: openjdk-25-jre is the Debian/Ubuntu package only. RHEL-based distros use java-25-openjdk, which matches the lgsm/data/*.csv dependency lists in LinuxGSM#4928.
  • Update warning: the "server files are newer than LinuxGSM's record" warning lives in update_hyt.sh, so it comes from update and check-update, not from details.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The check-update example omits the required ./hytserver command prefix.

Review effort: Balanced
Findings: 1 Low severity

Open (1)
What changed in this PR

Corrects Hytale dependency and update-warning documentation.

Changes:

  • Documents distro-specific Java 25 packages.
  • Corrects which commands display update warnings.
File Description
game-servers/​hytale.md Updates Hytale requirements and update guidance.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread game-servers/hytale.md Outdated
@dgibbs64
dgibbs64 merged commit 24428f0 into master Oct 4, 2026
4 checks passed
@dgibbs64
dgibbs64 deleted the docs/hytale-copilot-fixes branch October 4, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants