Skip to content

Implement per-kind light budgeting with device capability limits #2238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
4ian merged 1 commit into from
Aug 23, 2026
+24 −9
Merged

Implement per-kind light budgeting with device capability limits #2238

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 24 additions & 9 deletions extensions/reviewed/Light3D.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -774,18 +774,18 @@
"function getLightManager(runtimeScene) {",
" if (!runtimeScene.__lightManager) {",
" // Create the shared manager if necessary.",
" const threeRenderer = runtimeScene",
" .getGame()",
" .getRenderer()",
" .getThreeRenderer();",
" const requestedCount = isInGameEdition",
" ? editorLightCountMax : lightCountMax;",
" const requestedShadowCount = isInGameEdition",
" ? editorLightShadowCountMax : lightShadowCountMax;",
"",
" // The renderer is read anew on every recomputation: it may not",
" // exist yet when the manager is created on the first frame.",
" runtimeScene.__lightManager = new LightManager(",
" requestedCount, requestedShadowCount,",
" kindCount => computeDeviceLightBudget(threeRenderer, kindCount));",
" kindCount => computeDeviceLightBudget(",
" runtimeScene.getGame().getRenderer().getThreeRenderer(),",
" kindCount));",
" }",
" return runtimeScene.__lightManager;",
"}",
Expand Down Expand Up @@ -825,10 +825,16 @@
" this.objects.length = 0;",
" }",
"",
" /** Drop the farthest lights until the list fits its capacity again. */",
" trimToCapacity() {",
" while (this.objects.length > this.capacity.value) {",
" this.onDeletion(this.objects.pop().object);",
" }",
" }",
"",
" /**",
" * @param object {LightRuntimeObject}",
" * @param sortDistance {number} The squared distance to the camera, which",
" * more expensive lights can inflate to lose ties against cheaper ones.",
" * @param sortDistance {number} The squared distance to the camera.",
" */",
" insertByDistance(object, sortDistance) {",
" let insertionIndex = 0;",
Expand Down Expand Up @@ -955,6 +961,15 @@
" this.usedKinds.add(kind);",
" this.deviceBudget = this._computeDeviceBudget(this.usedKinds.size);",
"",
" // The budget just shrank: evict the lights that no longer fit, so",
" // that even this frame stays within what the device can take.",
" for (const list of this.visibleLists.values()) {",
" list.trimToCapacity();",
" }",
" for (const list of this.shadowLists.values()) {",
" list.trimToCapacity();",
" }",
"",
" if (this.deviceBudget.count < this._requestedCount.value",
" || this.deviceBudget.shadowCount",
" < this._requestedShadowCount.value) {",
Expand Down Expand Up @@ -1051,7 +1066,7 @@
"objectGroups": []
},
{
"description": "the maximum number of nearest lights displayed simultaneously.",
"description": "the maximum number of nearest lights displayed simultaneously, counted separately for each kind of light (point lights, spot lights, spot lights projecting a texture). Devices that can't take that many lights enforce a lower limit.",
"fullName": "Max lights count",
"functionType": "ExpressionAndCondition",
"name": "LightCountMax",
Expand Down Expand Up @@ -1124,7 +1139,7 @@
"objectGroups": []
},
{
"description": "the maximum number of nearest lights displayed with shadow simultaneously.",
"description": "the maximum number of nearest lights displayed with shadow simultaneously, counted separately for each kind of light (point lights, spot lights, spot lights projecting a texture). Devices that can't take that many shadows enforce a lower limit.",
"fullName": "Max lights with shadow count",
"functionType": "ExpressionAndCondition",
"name": "LightShadowCountMax",
Expand Down
Loading