Chore/upgrade build tooling audit - #6
Merged
Conversation
Replace the pre-commit hook's `npx lint-staged` with a direct node call to node_modules/lint-staged/bin/lint-staged.js to avoid Windows npx/WSL shebang failures (node is provided on PATH by husky init). Also delete docs/IMPROVEMENT_BACKLOG.md (backlog content removed/relocated).
Refine the PeriodicBreathingCard visual scale: clarify the bar's ×5 (0–20%) comment, move the 5% threshold marker down and shorten it, and replace the previous inline labels with absolutely positioned labels aligned to 0%, 5% (threshold) and 20%. Also replace several existing SCREENSHOTS (PL1–PL7) and add two new screenshots (SCREENSHOTS/PL8.png, SCREENSHOTS/PL9.png).
There was a problem hiding this comment.
Pull request overview
This pull request refactors the renderer’s PeriodicBreathingCard UI component for clearer structure/styling, adjusts the Husky pre-commit hook to run lint-staged via node for improved Windows compatibility, and removes a large documentation backlog file.
Changes:
- Refactored
PeriodicBreathingCard.jsxlayout/styling and standardized callback syntax for readability. - Updated
.husky/pre-committo invokelint-stagedvianodeinstead ofnpx. - Deleted
docs/IMPROVEMENT_BACKLOG.md(not mentioned in the PR description).
Reviewed changes
Copilot reviewed 3 out of 12 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/renderer/components/charts/PeriodicBreathingCard.jsx |
UI refactor/formatting changes to improve readability and visual consistency. |
docs/IMPROVEMENT_BACKLOG.md |
Removes the improvement backlog document from the repo. |
.husky/pre-commit |
Switches pre-commit execution from npx lint-staged to direct node invocation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1
to
+6
| # Call lint-staged's entry point directly via node instead of `npx`. | ||
| # The Windows `npx` wrapper has a `#!/usr/bin/env bash` shebang; under GUI git | ||
| # clients (GitHub Desktop) `env` resolves `bash` to the WSL launcher in | ||
| # System32, which fails on Windows paths (exit 127). Going straight to node | ||
| # avoids that shell entirely. node is put on PATH by ~/.config/husky/init.sh. | ||
| node "node_modules/lint-staged/bin/lint-staged.js" |
| @@ -1 +1,6 @@ | |||
| npx lint-staged | |||
| # Call lint-staged's entry point directly via node instead of `npx`. | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
PeriodicBreathingCard.jsxcomponent to improve code readability, maintainability, and UI consistency, and updates the Husky pre-commit hook for better cross-platform compatibility. The main changes are grouped below by theme.Code Quality and Readability Improvements:
PeriodicBreathingCard.jsxcomponent to consistently use arrow functions, improve indentation, and apply clearer, more readable inline styles for all UI elements. This includes updating all filter/map/reduce callbacks to arrow functions and cleaning up conditional expressions for color and label selection.Cross-Platform Tooling Fix:
.husky/pre-commithook to invokelint-stageddirectly withnodeinstead ofnpx, ensuring compatibility with Windows environments and GUI Git clients.Minor Content and Consistency Updates:
TOOLTIPobject and ensured consistent formatting of tooltip content.These changes collectively enhance maintainability, developer experience, and user interface consistency.