Skip to content

feat: support campaign co-creators and mobile image loading - #748

Closed
Fayedamz wants to merge 4 commits into
Fundable-Protocol:mainfrom
Fayedamz:feat/700-mobile-images-717-campaign-co-creators
Closed

feat: support campaign co-creators and mobile image loading#748
Fayedamz wants to merge 4 commits into
Fundable-Protocol:mainfrom
Fayedamz:feat/700-mobile-images-717-campaign-co-creators

Conversation

@Fayedamz

Copy link
Copy Markdown
Contributor

Summary
This PR addresses issues #700 and #717 in a single change set.
#700 — Fix mobile campaign image loading
Adds a reusable campaign detail image gallery with responsive image sizing. The hero image loads eagerly with high priority, while all below-the-fold images use lazy loading and asynchronous decoding to reduce mobile rendering jank on screens below 768px. Focused test coverage verifies the loading behavior.
#717 — Support campaign co-creation
Extends the campaign-funding contract to support multiple campaign creators with shared ownership and decision-making. Campaigns can now be created with an ordered list of creators and revenue shares expressed in basis points totaling 10,000. All creators must authorize shared actions, and successful campaign proceeds are distributed proportionally according to the configured shares.
The contract also exposes creator and revenue-share queries and supports adding co-creators before a campaign succeeds, while preserving backward compatibility with the existing single-creator campaign API.
Validation
Focused campaign image-gallery test passes.
Modified contract passes cargo check in a temporary workspace after removing the repository’s pre-existing duplicate soroban-sdk manifest key.
git diff --check passes.
Full frontend build/lint remains blocked by unrelated pre-existing errors, including duplicate Header exports and existing lint violations.

closes #700
closes #717

@drips-wave

drips-wave Bot commented Aug 28, 2026

Copy link
Copy Markdown

@Fayedamz Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: dd973de9-450d-4c1c-be2a-3a43291ba21d


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Utilitycoder Utilitycoder left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix up the merge conflict and update your PR. Kindly ensure you offramp with Fundable at https://stellar.fundable.finance/offramp

@Utilitycoder Utilitycoder left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix up the merge conflict and update your PR. Kindly ensure you offramp with Fundable at https://stellar.fundable.finance/offramp

@Idrhas

Idrhas commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Fix your conflicts to get PR merged, and don't forget to use https://stellar.fundable.finance for your offramps

@Fayedamz Fayedamz closed this Aug 31, 2026
@Fayedamz
Fayedamz deleted the feat/700-mobile-images-717-campaign-co-creators branch August 31, 2026 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(frontend): Campaign detail page images fail to load on mobile feat(contract): Campaign co-creation - multiple creators share campaign ownership

3 participants