Skip to content

refactor: migrate Cypress tests to Vitest#1347

Merged
benfrontify merged 15 commits into
mainfrom
CU-869d67ue9_migrate-tests-from-cypress-to-vitest_Ben-laemmlin
May 21, 2026
Merged

refactor: migrate Cypress tests to Vitest#1347
benfrontify merged 15 commits into
mainfrom
CU-869d67ue9_migrate-tests-from-cypress-to-vitest_Ben-laemmlin

Conversation

@benfrontify
Copy link
Copy Markdown
Contributor

No description provided.

@benfrontify benfrontify requested a review from a team as a code owner May 20, 2026 09:30
@benfrontify benfrontify requested a review from ragi96 May 20, 2026 09:30
@fulopdaniel
Copy link
Copy Markdown
Collaborator

@benfrontify benfrontify changed the title Cu 869d67ue9 migrate tests from cypress to vitest ben laemmlin fix: migrate Cypress tests to Vitest May 20, 2026
Copy link
Copy Markdown
Collaborator

@ragi96 ragi96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great there are more test on the Figma Block to migrate as well

Comment thread packages/figma-block/src/FigmaBlock.spec.tsx Outdated
Comment thread packages/figma-block/src/FigmaBlock.spec.tsx Outdated
@ragi96 ragi96 changed the title fix: migrate Cypress tests to Vitest refactor: migrate Cypress tests to Vitest May 20, 2026
@benfrontify benfrontify requested a review from ragi96 May 21, 2026 09:28
Copy link
Copy Markdown
Collaborator

@ragi96 ragi96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package.json adjustments missing

@benfrontify
Copy link
Copy Markdown
Contributor Author

tsconfig.json is pushed, but what is missing in package.json ?

@benfrontify benfrontify requested a review from ragi96 May 21, 2026 09:33
Comment thread packages/figma-block/src/components/ImageStageControls.spec.tsx Outdated
Comment thread packages/figma-block/tsconfig.json Outdated
Comment thread packages/figma-block/src/components/ImageStageControls.spec.tsx Outdated
@ragi96
Copy link
Copy Markdown
Collaborator

ragi96 commented May 21, 2026

tsconfig.json is pushed, but what is missing in package.json ?

You can remove the dependencies that are related to cypress and run pnpm i afterwards

@benfrontify benfrontify requested a review from ragi96 May 21, 2026 13:01
Copy link
Copy Markdown
Collaborator

@ragi96 ragi96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package.json adjustments still missing

@benfrontify
Copy link
Copy Markdown
Contributor Author

Oh yes, I overlooked that one

@benfrontify benfrontify requested a review from ragi96 May 21, 2026 13:15
Comment thread packages/figma-block/src/FigmaBlock.spec.tsx Outdated
@benfrontify benfrontify enabled auto-merge (squash) May 21, 2026 14:19
@benfrontify benfrontify requested a review from ragi96 May 21, 2026 14:30
@benfrontify benfrontify merged commit 2954a87 into main May 21, 2026
13 checks passed
@benfrontify benfrontify deleted the CU-869d67ue9_migrate-tests-from-cypress-to-vitest_Ben-laemmlin branch May 21, 2026 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants