Skip to content

feat(scope): change approach to scope everything #1330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ragi96 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat(scope): change approach to scope everything #1330

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions postcss/scope.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,21 +35,22 @@ module.exports = (opts = {}) => {

module.exports.postcss = true;

const tagSelectorRegex = /^[a-zA-Z][a-zA-Z0-9-]*$/;

const getScopedSelector = (selector, scope) => {
const trimmed = selector.trim();

// Replace :root with .selector, so variables are only applied to the block
if (selector === ":root") {
if (trimmed === ":root") {
return scope;
}

// Prefix all rules with .selector that match the condition
if (selector.includes("tw-") || tagSelectorRegex.test(selector)) {
return `${scope} ${selector}${getModalExtensions(selector)}`;
// Skip selectors that are already scoped (idempotency)
if (trimmed === scope || trimmed.startsWith(`${scope} `)) {
return selector;
}

// Return the original rule
return selector;
// Prefix every other selector with the scope. Class selectors also get the
// modal extensions so portaled content (dialogs, overlays, toolbars) keeps working.
return `${scope} ${trimmed}${getModalExtensions(trimmed)}`;
};

const getModalExtensions = (selector) => {
Expand Down