Harden shell command escaping and fix data storage bug#49
Open
niutech wants to merge 1 commit intoFreeterApp:masterfrom
Open
Harden shell command escaping and fix data storage bug#49niutech wants to merge 1 commit intoFreeterApp:masterfrom
niutech wants to merge 1 commit intoFreeterApp:masterfrom
Conversation
- In `src/main/base/apps/terminal.ts`, updated `escBackslashesDblQuotes` to escape `$` and `` ` `` characters to prevent command injection in double-quoted strings. - In `src/main/infra/dataStorage/fileDataStorage.ts`, added the missing `await` keyword to the `rm(filePath)` call in `deleteItem`. - In `src/main/infra/dataStorage/fileDataStorage.ts`, updated `setText` to use the sanitized `filePath` variable instead of `join(normStorageDirPath, key)`. Co-authored-by: niutech <384997+niutech@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/main/base/apps/terminal.ts, updatedescBackslashesDblQuotesto escape$and`characters to prevent command injection in double-quoted strings.src/main/infra/dataStorage/fileDataStorage.ts, added the missingawaitkeyword to therm(filePath)call indeleteItem.src/main/infra/dataStorage/fileDataStorage.ts, updatedsetTextto use the sanitizedfilePathvariable instead ofjoin(normStorageDirPath, key).